OV9

Son wants a new XBox for Christmas (He's paying half)

Is the XBox Series X 1 TB the one to go for ?

I would, that's what I have and find it good for everything. Not sure if it's available without the CD drive but I'd go for one with as you can pick up games for cheap on ebay etc.

We've got a disc edition and not used it once for anything with a disc

Either Game Pass or downloads is all we've ever had, worth it just in case maybe? Plays blu ray if that's still a thing?

I've got the Series X and I'd say it's probably still the one to go for. It's more expensive, but it does have a lot more compute power, so probably has the best chance of lasting for a longer period of use.

I have series X - Ive also put the storage expansion card in it. You'll want this for the extra space it gives you. For reference Call of Duty is now over 300gig installed.

Yeah the newer games are huge, I think Forza and GTA are 100gb+ each.